Security: Secure webhooks and prevent duplicate scheduled job executions - #4
Open
magqqgq wants to merge 1 commit into
Open
Security: Secure webhooks and prevent duplicate scheduled job executions#4magqqgq wants to merge 1 commit into
magqqgq wants to merge 1 commit into
Conversation
This PR remediates a HIGH-severity vulnerability where the job webhook endpoint accepted unsigned requests and lacked idempotency controls. These issues previously allowed unauthenticated users to trigger Inngest events arbitrarily, causing duplicate job runs and unmetered consumption of paid services. Changes: Provider Signature Verification: Integrated @upstash/qstash receiver validation in app/api/jobs/webhook/route.ts to strictly verify QStash signatures before processing any payloads. Error Propagation: The webhook now correctly returns a 500 status code upon inngest.send failures, properly allowing the upstream scheduler to retry delivery instead of swallowing errors and falsely returning a 200 OK. Idempotency & Replay Prevention: Implemented an atomic SETNX-based lock (checkAndLockMessage) in lib/jobs.ts mapped to the Upstash-Message-Id header to persist one-time delivery IDs. Atomic State Transition: Updated startJob to perform a state transition check. It now aggressively rejects duplicate execution requests if a job is already 'running' or 'complete'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR remediates a HIGH-severity vulnerability where the job webhook endpoint accepted unsigned requests and lacked idempotency controls. These issues previously allowed unauthenticated users to trigger Inngest events arbitrarily, causing duplicate job runs and unmetered consumption of paid services.
Changes:
Provider Signature Verification: Integrated @upstash/qstash receiver validation in app/api/jobs/webhook/route.ts to strictly verify QStash signatures before processing any payloads.
Error Propagation: The webhook now correctly returns a 500 status code upon inngest.send failures, properly allowing the upstream scheduler to retry delivery instead of swallowing errors and falsely returning a 200 OK.
Idempotency & Replay Prevention: Implemented an atomic SETNX-based lock (checkAndLockMessage) in lib/jobs.ts mapped to the Upstash-Message-Id header to persist one-time delivery IDs.
Atomic State Transition: Updated startJob to perform a state transition check. It now aggressively rejects duplicate execution requests if a job is already 'running' or 'complete'.